(WIP) Feat: Sentry Javascript V9 #4568

lucas-zimerman · 2025-02-19T12:37:45Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

This PR bumps JavaScript to version V9 and also fixes any break changes found.
In short, normal users not experience any changes, as shown on the sample apps, there were no required changes for this bump.

Changes handled:

In regard to shutdownTimeout, we can keep it as an additional parameter or completely remove it if that is the plan.

💡 Motivation and Context

💚 How did you test it?

Sample App, CI, Sentry.io discover

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Update Changelog with breakchanges.
Create Migration Doc.

#skip-changelog for now

github-actions · 2025-02-19T13:01:43Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1213.46 ms	1221.42 ms	7.96 ms
Size	2.63 MiB	3.73 MiB	1.10 MiB

Previous results on branch: lz/bump/jsv9

Startup times

Revision	Plain	With Sentry	Diff
`71f7309`+dirty	1222.02 ms	1224.81 ms	2.79 ms
`345e497`+dirty	1218.83 ms	1218.73 ms	-0.10 ms
`e54b1ed`+dirty	1227.33 ms	1254.46 ms	27.14 ms
`987dc4d`+dirty	1216.13 ms	1227.20 ms	11.08 ms

App size

Revision	Plain	With Sentry	Diff
`71f7309`+dirty	2.63 MiB	3.73 MiB	1.10 MiB
`345e497`+dirty	2.63 MiB	3.68 MiB	1.05 MiB
`e54b1ed`+dirty	2.63 MiB	3.68 MiB	1.05 MiB
`987dc4d`+dirty	2.63 MiB	3.73 MiB	1.10 MiB

github-actions · 2025-02-19T13:26:37Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	383.45 ms	415.65 ms	32.21 ms
Size	17.75 MiB	20.10 MiB	2.36 MiB

Previous results on branch: lz/bump/jsv9

Startup times

Revision	Plain	With Sentry	Diff
`71f7309`	412.45 ms	431.62 ms	19.18 ms
`345e497`	397.98 ms	423.40 ms	25.42 ms
`e54b1ed`	434.79 ms	429.52 ms	-5.27 ms
`987dc4d`	422.12 ms	478.34 ms	56.22 ms

App size

Revision	Plain	With Sentry	Diff
`71f7309`	17.75 MiB	20.10 MiB	2.36 MiB
`345e497`	17.75 MiB	20.10 MiB	2.36 MiB
`e54b1ed`	17.75 MiB	20.10 MiB	2.36 MiB
`987dc4d`	17.75 MiB	20.10 MiB	2.36 MiB

github-actions · 2025-02-19T13:36:43Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	426.84 ms	453.53 ms	26.69 ms
Size	7.15 MiB	8.37 MiB	1.22 MiB

Previous results on branch: lz/bump/jsv9

Startup times

Revision	Plain	With Sentry	Diff
`345e497`+dirty	375.33 ms	377.23 ms	1.90 ms
`71f7309`+dirty	361.15 ms	369.90 ms	8.75 ms
`e54b1ed`+dirty	435.06 ms	429.19 ms	-5.87 ms
`987dc4d`+dirty	411.89 ms	418.60 ms	6.71 ms

App size

Revision	Plain	With Sentry	Diff
`345e497`+dirty	7.15 MiB	8.37 MiB	1.22 MiB
`71f7309`+dirty	7.15 MiB	8.37 MiB	1.22 MiB
`e54b1ed`+dirty	7.15 MiB	8.37 MiB	1.22 MiB
`987dc4d`+dirty	7.15 MiB	8.37 MiB	1.22 MiB

github-actions · 2025-02-19T13:48:55Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1219.31 ms	1217.37 ms	-1.94 ms
Size	3.19 MiB	4.30 MiB	1.11 MiB

Previous results on branch: lz/bump/jsv9

Startup times

Revision	Plain	With Sentry	Diff
`71f7309`+dirty	1206.00 ms	1214.28 ms	8.28 ms
`345e497`+dirty	1210.67 ms	1207.50 ms	-3.17 ms
`e54b1ed`+dirty	1227.90 ms	1230.92 ms	3.02 ms
`987dc4d`+dirty	1209.94 ms	1215.25 ms	5.31 ms

App size

Revision	Plain	With Sentry	Diff
`71f7309`+dirty	3.19 MiB	4.30 MiB	1.11 MiB
`345e497`+dirty	3.19 MiB	4.25 MiB	1.06 MiB
`e54b1ed`+dirty	3.19 MiB	4.25 MiB	1.06 MiB
`987dc4d`+dirty	3.19 MiB	4.30 MiB	1.11 MiB

lucas-zimerman · 2025-02-24T14:31:54Z

I will wait for some information in regard to getsentry/sentry-javascript#15471 in case it's a problem on the JavaScript SDK

krystofwoldrich · 2025-02-25T10:21:46Z

@lucas-zimerman The yarn.lock seems to be completely regenerated.

How have you upgraded to the JS v9?

We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592

The yarn.lock change should be readable as only sentry deps should change.

lucas-zimerman · 2025-02-25T14:00:48Z

@lucas-zimerman The yarn.lock seems to be completely regenerated.

How have you upgraded to the JS v9?

We should review it and ensure only the @sentry/* are upgraded to avoid issues like #4592

The yarn.lock change should be readable as only sentry deps should change.

I fixed on 028dbf9, At the time there were a conflict with yarn.lock, and I created a new one. Next time I will get the target branch yarn.lock and install again on the PR

packages/core/package.json

krystofwoldrich · 2025-02-25T14:07:13Z

Thank you @lucas-zimerman, now the yarn.lock looks good.

packages/core/src/js/tracing/span.ts

lucas-zimerman · 2025-02-25T18:38:44Z

@antonis @krystofwoldrich I'd say now it's ready for review :D

packages/core/package.json

packages/core/src/js/integrations/reactnativeerrorhandlers.ts

antonis

Added a couple of nits but overall LGTM 🚀

…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction

lucas-zimerman added 4 commits February 14, 2025 14:02

bump SDKs

04b6c06

bump SDKs

0dc4bca

fix build

382fef6

fix tests

33af36c

fix tests

ad6a76c

lucas-zimerman added 3 commits February 19, 2025 11:17

fix lint errors

15342a2

test ts 5.0

c267f9b

rollback

efea84f

antonis mentioned this pull request Feb 19, 2025

chore(deps): Fixes JS SDK v9 breakages #4566

Closed

10 tasks

lucas-zimerman added the Blocked label Feb 24, 2025

Merge branch 'v7' into lz/bump/jsv9

65a10d5

antonis mentioned this pull request Feb 25, 2025

chore(dep): fix expo sample version to 52.0.19 #4592

Closed

10 tasks

lucas-zimerman removed the Blocked label Feb 25, 2025

krystofwoldrich reviewed Feb 25, 2025

View reviewed changes

packages/core/package.json Show resolved Hide resolved

lucas-zimerman commented Feb 25, 2025

View reviewed changes

packages/core/src/js/tracing/span.ts Show resolved Hide resolved

lucas-zimerman added 2 commits February 25, 2025 13:16

fix merge conflict with yarn

028dbf9

fix new lint issue

a57459a

lucas-zimerman marked this pull request as ready for review February 25, 2025 18:37

lucas-zimerman requested a review from antonis as a code owner February 25, 2025 18:37

antonis reviewed Feb 26, 2025

View reviewed changes

packages/core/package.json Outdated Show resolved Hide resolved

antonis reviewed Feb 26, 2025

View reviewed changes

packages/core/src/js/integrations/reactnativeerrorhandlers.ts Show resolved Hide resolved

antonis approved these changes Feb 26, 2025

View reviewed changes

lucas-zimerman added 11 commits February 26, 2025 09:22

sync yarn.lock with V7 branch and install new packages

5de9867

ensure we are using the JS version from the default node resolution

ae65521

update changelog with javascript version bump

bd64169

fix check type (#4587)

39a81c7

add major changes to the SDK

3a4fd4c

fix lint

d8088ad

review check: fix changelog PR number / Fix wrapper incorrect null c…

6f71cda

…heck / removed comment from rnerror handler / removed comment from span / fix test from userInteraction

fix incorrect cli version

55c1961

fix lint

97853c6

Merge branch 'v7' into lz/bump/jsv9

dc2e123

remove shutdowntimeout from android / use newer wizard version

9a0b21e

lucas-zimerman requested a review from krystofwoldrich March 3, 2025 21:15

lucas-zimerman mentioned this pull request Mar 3, 2025

fix(sdk): Set {{auto}} if user.ip_address is undefined #4466

Open

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(WIP) Feat: Sentry Javascript V9 #4568

(WIP) Feat: Sentry Javascript V9 #4568

lucas-zimerman commented Feb 19, 2025 •

edited

Loading

github-actions bot commented Feb 19, 2025 •

edited

Loading

Previous results on branch: lz/bump/jsv9

Startup times

App size

github-actions bot commented Feb 19, 2025 •

edited

Loading

Previous results on branch: lz/bump/jsv9

Startup times

App size

github-actions bot commented Feb 19, 2025 •

edited

Loading

Previous results on branch: lz/bump/jsv9

Startup times

App size

github-actions bot commented Feb 19, 2025 •

edited

Loading

Previous results on branch: lz/bump/jsv9

Startup times

App size

lucas-zimerman commented Feb 24, 2025

krystofwoldrich commented Feb 25, 2025

lucas-zimerman commented Feb 25, 2025

krystofwoldrich commented Feb 25, 2025

lucas-zimerman commented Feb 25, 2025

antonis left a comment

(WIP) Feat: Sentry Javascript V9 #4568

Are you sure you want to change the base?

(WIP) Feat: Sentry Javascript V9 #4568

Conversation

lucas-zimerman commented Feb 19, 2025 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Feb 19, 2025 • edited Loading

iOS (legacy) Performance metrics 🚀

Previous results on branch: lz/bump/jsv9

Startup times

App size

github-actions bot commented Feb 19, 2025 • edited Loading

Android (legacy) Performance metrics 🚀

Previous results on branch: lz/bump/jsv9

Startup times

App size

github-actions bot commented Feb 19, 2025 • edited Loading

Android (new) Performance metrics 🚀

Previous results on branch: lz/bump/jsv9

Startup times

App size

github-actions bot commented Feb 19, 2025 • edited Loading

iOS (new) Performance metrics 🚀

Previous results on branch: lz/bump/jsv9

Startup times

App size

lucas-zimerman commented Feb 24, 2025

krystofwoldrich commented Feb 25, 2025

lucas-zimerman commented Feb 25, 2025

krystofwoldrich commented Feb 25, 2025

lucas-zimerman commented Feb 25, 2025

antonis left a comment

Choose a reason for hiding this comment

lucas-zimerman commented Feb 19, 2025 •

edited

Loading

github-actions bot commented Feb 19, 2025 •

edited

Loading

github-actions bot commented Feb 19, 2025 •

edited

Loading

github-actions bot commented Feb 19, 2025 •

edited

Loading

github-actions bot commented Feb 19, 2025 •

edited

Loading